Skip to content

Introduce BridgeJS, a declarative JS interop system #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2025
Merged

Introduce BridgeJS, a declarative JS interop system #330

merged 6 commits into from
Apr 8, 2025

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Apr 2, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

Time Change: +300ms (2%)

Total Time: 10,125ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 26ms +3ms (9%) 🔍
Serialization/Swift Int to JavaScript with assignment 350ms +19ms (5%) 🔍
Serialization/JavaScript Number to Swift Int 278ms +17ms (6%) 🔍
Serialization/Swift String to JavaScript with call 1,121ms +61ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 21ms -1ms
Serialization/JavaScript function call from Swift 129ms -1ms
Serialization/Swift Int to JavaScript with call 1,013ms +30ms (2%)
Serialization/Swift String to JavaScript with assignment 430ms +19ms (4%)
Serialization/JavaScript String to Swift String 3,908ms +150ms (3%)
Object heap/Increment and decrement RC 2,809ms -1ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 10ms
Serialization/Assign JavaScript number directly 8ms
Serialization/Call with JavaScript number directly 7ms
Serialization/Write JavaScript string directly 8ms
Serialization/Call with JavaScript string directly 7ms

@kateinoigakukun kateinoigakukun requested a review from Copilot April 2, 2025 07:00
Copilot

This comment was marked as resolved.

Sign in to view

@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 2, 2025 11:47
@kateinoigakukun
Copy link
Member Author

Merging behind a feature flag

@kateinoigakukun kateinoigakukun merged commit 8a1007e into main Apr 8, 2025
7 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/import-export branch April 8, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun